Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions examples/range.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import moment, { Moment } from 'moment';
import type { Moment } from 'moment';
import moment from 'moment';
import RangePicker from '../src/RangePicker';
import momentGenerateConfig from '../src/generate/moment';
import zhCN from '../src/locale/zh_CN';
Expand Down Expand Up @@ -40,6 +41,11 @@ export default () => {

const rangePickerRef = React.useRef<RangePicker<Moment>>(null);

const now = momentGenerateConfig.getNow();
const disabledDate = (current: Moment) => {
return current.diff(now, 'days') > 1 || current.diff(now, 'days') < -1;
};

return (
<div>
<h2>Value: {value ? `${formatDate(value[0])} ~ ${formatDate(value[1])}` : 'null'}</h2>
Expand Down Expand Up @@ -67,7 +73,7 @@ export default () => {
ranges={{
ranges: [moment(), moment().add(10, 'day')],
}}
onOk={dates => {
onOk={(dates) => {
console.log('OK!!!', dates);
}}
/>
Expand Down Expand Up @@ -162,6 +168,16 @@ export default () => {
placeholder={['start...', 'end...']}
/>
</div>
<div style={{ margin: '0 8px' }}>
<h3>DisabledDate</h3>
<RangePicker<Moment>
{...sharedProps}
value={undefined}
locale={zhCN}
placeholder={['start...', 'end...']}
disabledDate={disabledDate}
/>
</div>
</div>
</div>
);
Expand Down
9 changes: 9 additions & 0 deletions src/RangePicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -603,6 +603,15 @@ function InnerRangePicker<DateType>(props: RangePickerProps<DateType>) {
triggerOpen(newOpen, index);
},
onSubmit: () => {
if (
// When user typing disabledDate with keyboard and enter, this value will be empty
!selectedValue ||
// Normal disabled check
(disabledDate && disabledDate(selectedValue[index]))
) {
return false;
}

triggerChange(selectedValue, index);
resetText();
},
Expand Down
25 changes: 25 additions & 0 deletions tests/range.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { act } from 'react-dom/test-utils';
import KeyCode from 'rc-util/lib/KeyCode';
import { spyElementPrototypes } from 'rc-util/lib/test/domHook';
import type { Moment } from 'moment';
import moment from 'moment';
import type { Wrapper } from './util/commonUtil';
import { mount, getMoment, isSame, MomentRangePicker } from './util/commonUtil';
import zhCN from '../src/locale/zh_CN';
Expand Down Expand Up @@ -1544,4 +1545,28 @@ describe('Picker.Range', () => {
wrapper.simulate('mouseleave');
expect(handleMouseLeave).toHaveBeenCalled();
});

// https://github.com/ant-design/ant-design/issues/31334
it('keyboard should not trigger on disabledDate', () => {
const onCalendarChange = jest.fn();
const now = moment();
const disabledDate = (current: Moment) => {
return current.diff(now, 'days') > 1 || current.diff(now, 'days') < -1;
};
const wrapper = mount(
<MomentRangePicker onCalendarChange={onCalendarChange} disabledDate={disabledDate} />,
);
wrapper.find('input').first().simulate('focus');
wrapper.keyDown(KeyCode.ENTER);
wrapper.keyDown(KeyCode.TAB);
// Make sure the selected value is disabledDate. Because only a few values are disabledDate
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.DOWN);
wrapper.keyDown(KeyCode.ENTER);
expect(onCalendarChange).not.toHaveBeenCalled();
});
});