Skip to content

test: fix test #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2022
Merged

test: fix test #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff49dc
test: fix test
MadCcc Jul 18, 2022
b353c79
chore: code clean
MadCcc Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"node": ">=8.x"
},
"devDependencies": {
"@testing-library/react": "^12",
"@types/classnames": "^2.2.9",
"@types/enzyme": "^3.10.3",
"@types/jest": "^26.0.0",
Expand Down
12 changes: 5 additions & 7 deletions tests/picker.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import moment from 'moment';
import type { Moment } from 'moment';
import type { PanelMode, PickerMode } from '../src/interface';
import { mount, getMoment, isSame, MomentPicker } from './util/commonUtil';
import { fireEvent, render } from '@testing-library/react';

describe('Picker.Basic', () => {
beforeAll(() => {
Expand Down Expand Up @@ -125,17 +126,14 @@ describe('Picker.Basic', () => {
it('fixed open need repeat trigger onOpenChange', () => {
jest.useFakeTimers();
const onOpenChange = jest.fn();
mount(<MomentPicker onOpenChange={onOpenChange} open />);
render(<MomentPicker onOpenChange={onOpenChange} open />);
expect(onOpenChange).toHaveBeenCalledTimes(0);

for (let i = 0; i < 10; i += 1) {
const clickEvent = new Event('mousedown');
Object.defineProperty(clickEvent, 'target', {
get: () => document.body,
});
act(() => {
window.dispatchEvent(clickEvent);
fireEvent.mouseDown(document.body);
});
expect(onOpenChange).toHaveBeenCalledTimes(i + 1);
expect(onOpenChange).toHaveBeenCalledTimes(1);
}
act(() => {
jest.runAllTimers();
Expand Down
19 changes: 6 additions & 13 deletions tests/range.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { Wrapper } from './util/commonUtil';
import { mount, getMoment, isSame, MomentRangePicker } from './util/commonUtil';
import zhCN from '../src/locale/zh_CN';
import type { PickerMode } from '../src/interface';
import { fireEvent, render } from '@testing-library/react';

describe('Picker.Range', () => {
function matchValues(wrapper: Wrapper, value1: string, value2: string) {
Expand Down Expand Up @@ -693,23 +694,15 @@ describe('Picker.Range', () => {
it('fixed open need repeat trigger onOpenChange', () => {
jest.useFakeTimers();
const onOpenChange = jest.fn();
const wrapper = mount(<MomentRangePicker onOpenChange={onOpenChange} open />);
render(<MomentRangePicker onOpenChange={onOpenChange} open />);

for (let i = 0; i < 10; i += 1) {
const clickEvent = new Event('mousedown');
Object.defineProperty(clickEvent, 'target', {
get: () => document.body,
});
expect(onOpenChange).toHaveBeenCalledTimes(0);

const current = onOpenChange.mock.calls.length;
for (let i = 0; i < 10; i += 1) {
act(() => {
window.dispatchEvent(clickEvent);
wrapper.find('input').first().simulate('blur');
fireEvent.mouseDown(document.body);
});
const next = onOpenChange.mock.calls.length;

// Maybe not good since onOpenChange trigger twice
expect(current < next).toBeTruthy();
expect(onOpenChange).toHaveBeenCalledTimes(1);
}
act(() => {
jest.runAllTimers();
Expand Down