Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/basic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export default () => {
<div style={{ margin: '0 8px' }}>
<h3>Basic</h3>
<Picker<Moment> {...sharedProps} locale={zhCN} />
<Picker<Moment> {...sharedProps} locale={enUS} />
</div>
<div style={{ margin: '0 8px' }}>
<h3>Uncontrolled</h3>
Expand Down
5 changes: 4 additions & 1 deletion src/generate/moment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ import { GenerateConfig } from '.';
const generateConfig: GenerateConfig<Moment> = {
// get
getNow: () => moment(),
getWeekDay: date => date.clone().locale('en_US').weekday(),
getWeekDay: date => {
const clone = date.clone().locale('en_US');
return clone.weekday() + clone.localeData().firstDayOfWeek();
},
getYear: date => date.year(),
getMonth: date => date.month(),
getDate: date => date.date(),
Expand Down
19 changes: 2 additions & 17 deletions src/utils/dateUtil.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { noteOnce } from 'rc-util/lib/warning';
import { GenerateConfig } from '../generate';
import { NullableDateType, PickerMode } from '../interface';

Expand Down Expand Up @@ -163,23 +162,9 @@ export function getWeekStartDate<DateType>(
) {
const weekFirstDay = generateConfig.locale.getWeekFirstDay(locale);
const monthStartDate = generateConfig.setDate(value, 1);
const startDateWeekDay = generateConfig.getWeekDay(monthStartDate);

for (let i = 0; i < 7; i += 1) {
const current = generateConfig.addDate(monthStartDate, -i);
if (generateConfig.getWeekDay(current) === weekFirstDay) {
return current;
}
}

/* istanbul ignore next */
/* eslint-disable no-lone-blocks */
{
noteOnce(
false,
'Not find week start date. Please check your `generateConfig`. If using default `generateConfig`, please help to fire a issue.',
);
return value;
}
return generateConfig.addDate(monthStartDate, weekFirstDay - startDateWeekDay);
}

export function getClosingViewDate<DateType>(
Expand Down
29 changes: 29 additions & 0 deletions tests/panel.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -437,5 +437,34 @@ describe('Picker.Panel', () => {
});
},
);

it('update firstDayOfWeek', () => {
const defaultFirstDay = moment(enUS.locale)
.localeData()
.firstDayOfWeek();
moment.updateLocale(enUS.locale, {
week: {
dow: 5,
} as any,
});
expect(defaultFirstDay).toEqual(0);

const wrapper = mount(
<MomentPickerPanel defaultValue={getMoment('2020-04-02')} locale={enUS} />,
);

expect(
wrapper
.find('td')
.first()
.text(),
).toEqual('27');

moment.updateLocale(enUS.locale, {
week: {
dow: defaultFirstDay,
} as any,
});
});
});
});