Skip to content

Conversation

hihuz
Copy link
Contributor

@hihuz hihuz commented Apr 1, 2023

Context

In the PR adding the luxon integration, the peer dependencies were not updated properly.

The PR was open for quite some time and the project structure evolved in the meantime, I forgot to adjust this part on the latest rebase.

Content

Simply adding the missing dependencies.

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2023 1:47pm

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #611 (ce2f4c4) into master (e62e0e2) will not change coverage.
The diff coverage is n/a.

❗ Current head ce2f4c4 differs from pull request most recent head 729c296. Consider uploading reports for the commit 729c296 to get more accurate results

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          51       51           
  Lines        2351     2351           
  Branches      687      687           
=======================================
  Hits         2336     2336           
  Misses         13       13           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoyo837 yoyo837 merged commit 02d5ac2 into react-component:master Apr 1, 2023
@hihuz
Copy link
Contributor Author

hihuz commented Apr 2, 2023

Thanks a lot @yoyo837 🙏 Don't we want to create a new release for the package to include these changes in antd?

@yoyo837
Copy link
Member

yoyo837 commented Apr 3, 2023

Thanks a lot @yoyo837 🙏 Don't we want to create a new release for the package to include these changes in antd?

antd uses ~ depends on rc-picker in package.json, we just need to make sure that antd uses rc-picker@3.4.0+.

@hihuz
Copy link
Contributor Author

hihuz commented Apr 3, 2023

Right! I missed that, thanks for the answer, and thank you for taking the time to review the PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants