Skip to content

change event binding to slider ownerDocument#326

Merged
benjycui merged 2 commits intoreact-component:masterfrom
zvcolpdy:events-in-frame
Oct 18, 2017
Merged

change event binding to slider ownerDocument#326
benjycui merged 2 commits intoreact-component:masterfrom
zvcolpdy:events-in-frame

Conversation

@zvcolpdy
Copy link
Contributor

@zvcolpdy zvcolpdy commented Oct 3, 2017

I noticed a problem that events binding to document. It has problem in frames that has they own document. It is better to use el.ownerDocument to add all slider event listeners.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.739% when pulling 88e1375 on polkpolio1:events-in-frame into 0a07ada on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.739% when pulling 6f1867b on polkpolio1:events-in-frame into 0a07ada on react-component:master.

@benjycui
Copy link
Member

Agree, but could you just show the problem with online demo? Thanks.

Please provide a re-producible demo: http://codepen.io/benjycui/pen/aJooRE?editors=0011

@zvcolpdy
Copy link
Contributor Author

@benjycui benjycui merged commit aae0498 into react-component:master Oct 18, 2017
@benjycui
Copy link
Member

8.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants