Skip to content

Conversation

paranoidjk
Copy link
Member

@paranoidjk paranoidjk commented Aug 28, 2017

close #42

@paranoidjk
Copy link
Member Author

@silentcloud 这个如果 ok 的话,发个大版本。

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 92.233% when pulling d6ab91c on rc-gesture into 710722d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 92.233% when pulling d6ab91c on rc-gesture into 710722d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 92.233% when pulling 1e82ff4 on rc-gesture into 1625dbe on master.

@silentcloud
Copy link
Member

silentcloud commented Aug 29, 2017

@paranoidjk 真机页面超过一屏就不能滚动了(含gesture 元素上下滑动),应该是 gesture 有问题

@silentcloud
Copy link
Member

@silentcloud
Copy link
Member

还有2个问题:1. 左右滑动 swipe 的时候,会导致页面上下滚动 2.快速 swipe 的时候,button 延迟 1s 左右才出现

@paranoidjk paranoidjk changed the title Replace rc-hammer.js with rc-gesture WIP Replace rc-hammer.js with rc-gesture Aug 29, 2017
@paranoidjk
Copy link
Member Author

paranoidjk commented Aug 29, 2017

Todo

  • 真机页面超过一屏就不能滚动了 : 不 preventDefault, 采用 css touch-action http://hammerjs.github.io/touch-action/
  • 快速 swipe 的时候,button 延迟 1s 左右才出现 @silentcloud 只有钱包内可以复现?浏览器正常
  • 左右滑动 swipe 的时候,会导致页面上下滚动

@silentcloud
Copy link
Member

  • 快速 swipe 的时候,button 延迟 1s 左右才出现 @silentcloud 只有钱包内可以复现?浏览器正常

这个我是在 antd-mobile 里用 2.0.0-alpha.0 在 webview 里测了一下

@paranoidjk
Copy link
Member Author

@silentcloud 再测一下?

@paranoidjk paranoidjk changed the title WIP Replace rc-hammer.js with rc-gesture Replace rc-hammer.js with rc-gesture Aug 29, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 92.233% when pulling eb9df86 on rc-gesture into 1625dbe on master.

@silentcloud
Copy link
Member

silentcloud commented Aug 29, 2017

  • 左右滑动 swipe 的时候,会导致页面上下滚动

横向滑动,稍微斜一点,问题依旧, @paranoidjk

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 92.233% when pulling 2dc492f on rc-gesture into 1625dbe on master.

@paranoidjk
Copy link
Member Author

@silentcloud 都修复了,你验证下?我这边看只剩一个问题 #42

要么把事件代理到 window,要么在 touchmove 中维持计时器,我再想想

@paranoidjk
Copy link
Member Author

加了 swipe 的支持,感觉体验好一点

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 91.429% when pulling 3dc7a08 on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 91.429% when pulling 28333d0 on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 91.429% when pulling 2d248f2 on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 91.429% when pulling c67718e on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 91.509% when pulling b698000 on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 91.589% when pulling b698000 on rc-gesture into 1625dbe on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.1%) to 87.85% when pulling e4ca6fc on rc-gesture into 1625dbe on master.

transition: all 250ms;
}
&-swiping .@{swipeout-prefix-cls}-content {
transition: none;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @silentcloud antd-mobile 层面可能也要做这个处理 #44

虽然 swiping 这个 classname 实测动态的加和删也有点跟不太上。

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 91.589% when pulling 20d7296 on rc-gesture into 1625dbe on master.

@paranoidjk
Copy link
Member Author

@silentcloud 这个可以合并了

@paranoidjk
Copy link
Member Author

升大版本吧,只给 antd-mobile@2.0 用,1.0 不改。

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 91.509% when pulling a22f1cc on rc-gesture into 1625dbe on master.

@paranoidjk paranoidjk merged commit 996d3da into master Sep 4, 2017
@paranoidjk paranoidjk deleted the rc-gesture branch September 4, 2017 06:04
@silentcloud
Copy link
Member

silentcloud commented Sep 4, 2017

@paranoidjk 我之前说的问题解决了?那些问题我还没来得及看呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panend not trigger in newer android chrome

4 participants