Skip to content

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Nov 15, 2016

有个问题就是原来 columns 里的 key 不能直接用在 <Column /> 里了,会访问不到,我暂时用 colKey 代替了,或者有更好的处理方法? @afc163

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 82.736% when pulling d5f336a on jsx-column into a412d0e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 82.736% when pulling d5f336a on jsx-column into a412d0e on master.

@yesmeck yesmeck changed the title JSX column API [WIP]JSX column API Nov 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 83.713% when pulling 273299c on jsx-column into a412d0e on master.

@afc163
Copy link
Member

afc163 commented Nov 15, 2016

可以参考:https://github.com/react-component/menu/ 通过 cloneElement 拿到 key 。

@yesmeck yesmeck changed the title [WIP]JSX column API JSX column API Nov 16, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 82.287% when pulling d96c122 on jsx-column into a412d0e on master.

@yesmeck
Copy link
Member Author

yesmeck commented Nov 16, 2016

@afc163 这个应该可以了

@afc163 afc163 merged commit 10b985d into master Nov 16, 2016
@benjycui
Copy link
Member

还有一个问题,这个应该成为推荐的语法么?

@afc163
Copy link
Member

afc163 commented Nov 17, 2016

先不推荐,文档里要补充上明显的版本说明,避免 2.4 之前的用户使用了没效果。

@afc163
Copy link
Member

afc163 commented Nov 17, 2016

回错地方。

@afc163 afc163 deleted the jsx-column branch November 17, 2016 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants