Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added examples/jsx.html
Empty file.
49 changes: 49 additions & 0 deletions examples/jsx.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/* eslint-disable no-console,func-names,react/no-multi-comp */
const React = require('react');
const ReactDOM = require('react-dom');
const Table = require('rc-table');
require('rc-table/assets/index.less');

const { ColumnGroup, Column } = Table;

const data = [
{ a: '123', key: '1' },
{ a: 'cdd', b: 'edd', key: '2' },
{ a: '1333', c: 'eee', d: 2, key: '3' },
];

ReactDOM.render(
<div>
<h2>JSX table</h2>
<Table data={data}>
<ColumnGroup title="Bazinga">
<Column
title="title1"
dataIndex="a"
key="a"
width={100}
/>
<Column
id="123"
title="title2"
dataIndex="b"
key="b"
width={100}
/>
</ColumnGroup>
<Column
title="title3"
dataIndex="c"
key="c"
width={200}
/>
<Column
title="Operations"
dataIndex=""
key="d"
render={() => <a href="#">Operations</a>}
/>
</Table>
</div>,
document.getElementById('__react-content')
);
21 changes: 21 additions & 0 deletions src/Column.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { Component, PropTypes } from 'react';

export default class Column extends Component {
static propTypes = {
className: PropTypes.string,
colSpan: PropTypes.number,
title: PropTypes.node,
dataIndex: PropTypes.string,
width: PropTypes.oneOfType([
PropTypes.number,
PropTypes.string,
]),
fixed: PropTypes.oneOf([
true,
'left',
'right',
]),
render: PropTypes.func,
onCellClick: PropTypes.func,
}
}
7 changes: 7 additions & 0 deletions src/ColumnGroup.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { Component, PropTypes } from 'react';

export default class ColumnGroup extends Component {
static propTypes = {
title: PropTypes.node,
}
}
33 changes: 29 additions & 4 deletions src/ColumnManager.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import React from 'react';
import Column from './Column';
import ColumnGroup from './ColumnGroup';

export default class ColumnManager {
_cached = {}

constructor(columns) {
this.columns = columns;
constructor(columns, elements) {
this.columns = columns || this.normalize(elements);
}

static includesCustomRender(columns) {
Expand Down Expand Up @@ -109,8 +113,29 @@ export default class ColumnManager {
});
}

reset(columns) {
this.columns = columns;
normalize(elements) {
const columns = [];
React.Children.forEach(elements, element => {
if (!this.isColumnElement(element)) return;
const clonedElement = React.cloneElement(element);
const column = { ...clonedElement.props };
if (clonedElement.key) {
column.key = clonedElement.key;
}
if (element.type === ColumnGroup) {
column.children = this.normalize(column.children);
}
columns.push(column);
});
return columns;
}

isColumnElement(element) {
return element && (element.type === Column || element.type === ColumnGroup);
}

reset(columns, elements) {
this.columns = columns || this.normalize(elements);
this._cached = {};
}

Expand Down
9 changes: 5 additions & 4 deletions src/Table.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ const Table = React.createClass({
scroll: PropTypes.object,
rowRef: PropTypes.func,
getBodyWrapper: PropTypes.func,
children: PropTypes.node,
},

getDefaultProps() {
return {
data: [],
useFixedHeader: false,
expandIconAsCell: false,
columns: [],
defaultExpandAllRows: false,
defaultExpandedRowKeys: [],
rowKey: 'key',
Expand Down Expand Up @@ -71,8 +71,7 @@ const Table = React.createClass({
const props = this.props;
let expandedRowKeys = [];
let rows = [...props.data];

this.columnManager = new ColumnManager(props.columns);
this.columnManager = new ColumnManager(props.columns, props.children);
this.store = createStore({ currentHoverKey: null });

if (props.defaultExpandAllRows) {
Expand Down Expand Up @@ -118,8 +117,10 @@ const Table = React.createClass({
expandedRowKeys: nextProps.expandedRowKeys,
});
}
if (nextProps.columns !== this.props.columns) {
if (nextProps.columns && nextProps.columns !== this.props.columns) {
this.columnManager.reset(nextProps.columns);
} else if (nextProps.children !== this.props.children) {
this.columnManager.reset(null, nextProps.children);
}
},

Expand Down
9 changes: 8 additions & 1 deletion src/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
module.exports = require('./Table');
const Table = require('./Table');
const Column = require('./Column');
const ColumnGroup = require('./ColumnGroup');

Table.Column = Column;
Table.ColumnGroup = ColumnGroup;

module.exports = Table;
52 changes: 52 additions & 0 deletions tests/ColumnManager.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
/* eslint-disable no-console,func-names,react/no-multi-comp,indent */
const React = require('react');
const expect = require('expect.js');
const ColumnManager = require('../src/ColumnManager');
const Column = require('../src/Column');
const ColumnGroup = require('../src/ColumnGroup');

describe('ColumnManager', () => {
describe('includesCustomRender', () => {
Expand Down Expand Up @@ -94,4 +97,53 @@ describe('ColumnManager', () => {
]);
});
});

describe('normalize', () => {
it('normalize React elements to columns', () => {
const elements = [
<ColumnGroup title="a">
<Column
title="b"
dataIndex="b"
key="b"
/>
<Column
title="c"
dataIndex="c"
key="c"
/>
</ColumnGroup>,
<Column
title="d"
dataIndex="d"
key="d"
/>,
];

const columnManager = new ColumnManager(null, elements);

expect(columnManager.columns).to.eql([
{
title: 'a',
children: [
{
title: 'b',
dataIndex: 'b',
key: 'b',
},
{
title: 'c',
dataIndex: 'c',
key: 'c',
},
],
},
{
title: 'd',
dataIndex: 'd',
key: 'd',
},
]);
});
});
});