fix: show ColGroup always #1317
Conversation
…lder and Table components
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a fix to ensure that the ColGroup component is always rendered within the table's fixed header. Previously, its rendering was conditional based on factors like noData, maxContentScroll, or whether all columns had explicit widths. By removing these conditions and related properties, the change guarantees consistent rendering of the column group, likely resolving display issues in specific table configurations.
Highlights
- Removed
maxContentScrollproperty: ThemaxContentScrollproperty has been removed from theFixedHeaderPropsinterface and its usage within theFixedHoldercomponent, simplifying the component's API and internal logic. - Eliminated unnecessary memoization: The
allFlattenColumnsWithWidthmemoized value, which was previously used in a conditional rendering check, has been removed as it is no longer necessary. - Ensured
ColGroupis always rendered: The conditional rendering logic for theColGroupcomponent has been removed, ensuring thatColGroupis always rendered. This change directly addresses the PR's title to 'show ColGroup always'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request simplifies the rendering logic within the FixedHolder component by ensuring the ColGroup is always rendered. This is achieved by removing a complex conditional check and the associated props (maxContentScroll) and state (allFlattenColumnsWithWidth) that were used to determine its visibility. The change correctly addresses a likely bug where the header column layout could break in specific scenarios (e.g., an empty table with scroll.x='max-content'). The resulting code is cleaner, more maintainable, and more robust.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1317 +/- ##
============================================
- Coverage 97.74% 97.74% -0.01%
============================================
Files 77 77
Lines 7635 7628 -7
Branches 1158 1155 -3
============================================
- Hits 7463 7456 -7
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ant-design/ant-design#54741