Revert "fix: show ColGroup always" #1320
Conversation
… FixedHo…" This reverts commit ce95747.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reverts the changes introduced in react-component/table#1317. The original change aimed to always render the ColGroup component, but this revert reintroduces conditional rendering for ColGroup within the FixedHolder component. This ensures that ColGroup is only rendered when necessary, specifically preventing its display when there is no data, maxContentScroll is enabled, and not all columns have an explicit width. This change likely addresses an issue or undesirable behavior caused by the ColGroup always being present.
Highlights
- Reverted ColGroup Rendering Logic: The
ColGroupcomponent withinsrc/FixedHolder/index.tsxno longer renders unconditionally. Its rendering is now dependent onnoData, a newmaxContentScrollprop, and whether all columns have a defined width, effectively reverting the 'always show' behavior. - Introduced
maxContentScrollProp: A new boolean propmaxContentScrollhas been added toFixedHeaderPropsinsrc/FixedHolder/index.tsxand is passed fromsrc/Table.tsx. This prop indicates if horizontal scrolling is enabled with amax-contentwidth, influencingColGroupvisibility. - Column Width Check: A new
useMemohookallFlattenColumnsWithWidthwas added tosrc/FixedHolder/index.tsxto determine if all flattened columns have a specified width. This check is crucial for the updatedColGrouprendering condition.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that made ColGroup always visible. The revert introduces a condition to render ColGroup only in specific scenarios, effectively hiding it when there is no data, horizontal scrolling is set to max-content, and not all columns have a defined width. This appears to be a targeted fix for a layout issue related to max-content scrolling. The changes in FixedHolder/index.tsx and Table.tsx are consistent and correctly implement this logic. The use of React.useMemo for calculating allFlattenColumnsWithWidth is appropriate for performance. Overall, the changes look correct and seem to be a sound approach to resolving the underlying issue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1320 +/- ##
=========================================
Coverage 97.74% 97.74%
=========================================
Files 77 77
Lines 7625 7625
Branches 1155 1155
=========================================
Hits 7453 7453
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #1317
ant-design/ant-design#54741 (comment)
不对，先回滚。