-
-
Notifications
You must be signed in to change notification settings - Fork 618
fix: column header not align before column width being calculated #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1332 +/- ##
=========================================
Coverage 97.74% 97.75%
=========================================
Files 77 77
Lines 7641 7646 +5
Branches 1156 1156
=========================================
+ Hits 7469 7474 +5
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
此拉取请求解决了表格组件中列头在初始渲染时可能出现的视觉对齐异常。通过为列组实现条件渲染策略,系统现在可以在列宽计算尚未完成时优雅地回退到默认布局,从而确保从首次渲染开始就显示一致且对齐的界面。
Highlights
- 修复列头对齐问题: 解决了在列宽计算完成前,列头出现对齐问题的情况。
- 条件性 ColGroup 渲染: 引入了一个新的辅助函数 getColGroup,用于根据条件渲染合适的 ColGroup 组件。
- 回退到原始 ColGroup: 确保在没有数据或列宽尚未计算时,使用原始的 ColGroup,从而避免视觉上的小故障。
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在修复表格在列宽计算完成前表头与列内容未对齐的问题。通过引入 getColGroup
函数,在 mergedColumnWidth
不存在时回退使用原始的 colGroup
,有效地解决了该对齐问题。代码变更逻辑清晰且正确。我提出了一项关于性能优化的建议,即使用 useMemo
来记忆化 ColGroup
的计算结果,以避免不必要的重复渲染。
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a column header alignment issue that occurs before column widths are calculated, preventing misalignment in the first frame of rendering.
- Extracts ColGroup rendering logic into a memoized component to improve performance
- Updates the condition to use original ColGroup when either no data exists or column widths haven't been calculated yet
- Simplifies the JSX by replacing inline conditional rendering with a pre-computed component
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
第一张图片,column 1 跟 column 2 下面得数据没对齐 |
第一张图片,column 1 跟 column 2 下面的数据没对齐 |
@crazyair 对的,这是问题重现的图片。 |
解决第一帧对不齐的问题,如果列宽度未计算出来时,直接使用自带的 bodyColGroup。cc @crazyair