Skip to content

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 2, 2025

图片 图片

解决第一帧对不齐的问题,如果列宽度未计算出来时,直接使用自带的 bodyColGroup。cc @crazyair

@afc163 afc163 requested a review from Copilot September 2, 2025 15:22
Copy link

coderabbitai bot commented Sep 2, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sticky-table-header-scrollable-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.75%. Comparing base (5531b2a) to head (bdf9ba7).
⚠️ Report is 2 commits behind head on antd-5.x.

Additional details and impacted files
@@            Coverage Diff            @@
##           antd-5.x    #1332   +/-   ##
=========================================
  Coverage     97.74%   97.75%           
=========================================
  Files            77       77           
  Lines          7641     7646    +5     
  Branches       1156     1156           
=========================================
+ Hits           7469     7474    +5     
  Misses          166      166           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求解决了表格组件中列头在初始渲染时可能出现的视觉对齐异常。通过为列组实现条件渲染策略,系统现在可以在列宽计算尚未完成时优雅地回退到默认布局,从而确保从首次渲染开始就显示一致且对齐的界面。

Highlights

  • 修复列头对齐问题: 解决了在列宽计算完成前,列头出现对齐问题的情况。
  • 条件性 ColGroup 渲染: 引入了一个新的辅助函数 getColGroup,用于根据条件渲染合适的 ColGroup 组件。
  • 回退到原始 ColGroup: 确保在没有数据或列宽尚未计算时,使用原始的 ColGroup,从而避免视觉上的小故障。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在修复表格在列宽计算完成前表头与列内容未对齐的问题。通过引入 getColGroup 函数,在 mergedColumnWidth 不存在时回退使用原始的 colGroup,有效地解决了该对齐问题。代码变更逻辑清晰且正确。我提出了一项关于性能优化的建议,即使用 useMemo 来记忆化 ColGroup 的计算结果,以避免不必要的重复渲染。

Copilot

This comment was marked as outdated.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
table Ready Ready Preview Comment Sep 2, 2025 3:26pm

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@afc163 afc163 requested a review from Copilot September 2, 2025 15:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a column header alignment issue that occurs before column widths are calculated, preventing misalignment in the first frame of rendering.

  • Extracts ColGroup rendering logic into a memoized component to improve performance
  • Updates the condition to use original ColGroup when either no data exists or column widths haven't been calculated yet
  • Simplifies the JSX by replacing inline conditional rendering with a pre-computed component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@crazyair
Copy link
Contributor

crazyair commented Sep 2, 2025

第一张图片,column 1 跟 column 2 下面得数据没对齐

@crazyair
Copy link
Contributor

crazyair commented Sep 2, 2025

第一张图片,column 1 跟 column 2 下面的数据没对齐

@afc163
Copy link
Member Author

afc163 commented Sep 2, 2025

@crazyair 对的,这是问题重现的图片。

@afc163 afc163 merged commit 46a165d into antd-5.x Sep 2, 2025
10 checks passed
@afc163 afc163 deleted the fix/sticky-table-header-scrollable-style branch September 2, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants