Skip to content

fix: column header not align before column width being calculated #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

fix: column header not align before column width being calculated #1332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3bc9ce
refactor: extract colGroup logic into getColGroup function
afc163 Sep 2, 2025
bf71c7e
Update src/FixedHolder/index.tsx
afc163 Sep 2, 2025
bdf9ba7
Update src/FixedHolder/index.tsx
afc163 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/FixedHolder/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,20 @@ const FixedHolder = React.forwardRef<HTMLDivElement, FixedHeaderProps<any>>((pro

const mergedColumnWidth = useColumnWidth(colWidths, columCount);

const colGroupNode = useMemo(() => {
// use original ColGroup if no data or no calculated column width, otherwise use calculated column width
if (noData || !mergedColumnWidth) {
return colGroup;
}
return (
<ColGroup
colWidths={[...mergedColumnWidth, combinationScrollBarSize]}
columCount={columCount + 1}
columns={flattenColumnsWithScrollbar}
/>
);
}, [noData, mergedColumnWidth, colGroup, combinationScrollBarSize, columCount, flattenColumnsWithScrollbar]);

return (
<div
style={{
Expand All @@ -155,16 +169,7 @@ const FixedHolder = React.forwardRef<HTMLDivElement, FixedHeaderProps<any>>((pro
...scrollTableStyle,
}}
>
{/* use original ColGroup if no data, otherwise use calculated column width */}
{noData ? (
colGroup
) : (
<ColGroup
colWidths={mergedColumnWidth ? [...mergedColumnWidth, combinationScrollBarSize] : []}
columCount={columCount + 1}
columns={flattenColumnsWithScrollbar}
/>
)}
{colGroupNode}
{children({
...restProps,
stickyOffsets: headerStickyOffsets,
Expand Down