Skip to content

Conversation

@TaueFenCheng
Copy link
Contributor

@TaueFenCheng TaueFenCheng commented Oct 20, 2025

fix online demo link & remove useless npm pkg

Summary by CodeRabbit

发版说明

  • 文档更新

    • 更新了在线演示地址至新的托管平台
    • 更新了 GitHub Actions 工作流程引用
    • 移除了过期的依赖项徽章
  • 构建配置

    • 更新了部署配置以支持新的托管环境

tjq added 3 commits October 20, 2025 13:02
更新 vercel.json 配置文件以适配 Vercel 部署要求,并同步更新 README 中的 CI 徽章链接和在线演示地址
@vercel
Copy link

vercel bot commented Oct 20, 2025

Someone is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

概览

该变更涉及项目配置更新:GitHub Actions工作流引用改为最新路径,移除David-DM徽章,更新在线演示URL至Vercel部署地址;移除cross-env开发依赖;将Vercel配置从框架模式迁移至v2标准格式。

变更

变更组 / 文件 摘要
文档和徽章更新
README.md
更新GitHub Actions工作流URL引用至react-component-ci.yml路径;移除David-DM依赖监测徽章;将演示URL从GitHub Pages迁移至Vercel (tooltip-react-component.vercel.app/)
依赖移除
package.json
从devDependencies中移除cross-env
部署配置迁移
vercel.json
将配置从框架定义模式(umijs)改为Vercel v2标准格式;新增schema、version及project name字段;引入static-build配置且指定dist目录

预估代码审查工作量

🎯 1 (简单) | ⏱️ ~8 分钟

建议审查者

  • zombieJ

🐰 徽章整理,配置焕新,
Vercel部署展风采,
cross-env告别道珍重,
文档更新指路明,
项目轻装再起航! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed PR标题"docs: fix online demo link"确实与变更集相关联。标题正确地识别了README中的一个关键变更——将在线演示链接从旧的GitHub Pages URL更新为新的Vercel URL。虽然变更集还包括package.json中的依赖项移除和vercel.json配置的迁移,但根据评估标准,标题不需要覆盖每个细节,只需清楚地总结主要变更即可。标题准确指向了变更的一个重要方面,并且是具体且清晰的,避免了模糊的用语。
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @TaueFenCheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential maintenance tasks, ensuring the project's documentation remains accurate and its build infrastructure is optimized. It updates outdated links in the README.md, removes an unnecessary development dependency, and modernizes the Vercel deployment configuration for improved clarity and maintainability.

Highlights

  • Documentation Updates: The README.md file has been updated to reflect current GitHub Actions badge URLs and to point the online demo link to a new Vercel deployment.
  • Dependency Cleanup: The cross-env development dependency has been removed from package.json, streamlining the project's dependencies.
  • Vercel Configuration Modernization: The vercel.json file has been refactored to use a more explicit and detailed Vercel configuration for static builds, including schema, version, and build specifics.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the online demo link to a new Vercel-hosted URL, removes defunct dependency badges (David DM), and cleans up an unused npm package (cross-env). The GitHub Actions badge URL is also corrected. The configuration for Vercel deployment is added in vercel.json. The changes are logical and improve the project's maintenance. I have one suggestion to improve the consistency of the Vercel configuration.

}
"$schema": "https://openapi.vercel.sh/vercel.json",
"version": 2,
"name": "@rc-component/tooltip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The name property in vercel.json is used for the Vercel project name. Using the scoped package name @rc-component/tooltip is unconventional and doesn't match the project name tooltip-react-component implied by the new demo URL (https://tooltip-react-component.vercel.app/). This inconsistency can cause confusion and issues when deploying or linking the project with the Vercel CLI. To improve clarity and consistency, it's recommended to use a name that matches the Vercel project.

Suggested change
"name": "@rc-component/tooltip",
"name": "tooltip-react-component",

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc474f7 and d28d29f.

📒 Files selected for processing (3)
  • README.md (2 hunks)
  • package.json (0 hunks)
  • vercel.json (1 hunks)
💤 Files with no reviewable changes (1)
  • package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

65-65: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (2)
vercel.json (1)

2-14: Vercel v2配置看起来良好。

配置已正确迁移至Vercel v2标准。@vercel/static-build使用package.json作为依赖项获取和指定构建方式,期望输出到dist或通过distDir配置项指定的目录。

请确保 package.json 中已配置对应的 now-build 脚本来生成 dist 目录的内容。

README.md (1)

16-17: GitHub Actions工作流URL已正确更新。

工作流路径已从旧的CI配置更新为新的 react-component-ci.yml,与Vercel部署迁移保持一致。

@TaueFenCheng TaueFenCheng changed the title Fix online demolink docs: fix online demo link Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fc474f7) to head (d28d29f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           37        37           
  Branches        15        15           
=========================================
  Hits            37        37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@afc163 afc163 merged commit 2b96da4 into react-component:master Oct 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants