Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Mar 22, 2020

antd master 上现在有两个 rc-tree,避免未来也打入两份,底层需要固定版本。

image

我另外发个 PR 到 3.0.x 上。

@vercel
Copy link

vercel bot commented Mar 22, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/tree-select/pqtghstq2
✅ Preview: https://tree-select-git-fix-bundle-size.react-component.now.sh

@afc163 afc163 requested a review from zombieJ March 22, 2020 13:40
@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #228 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          11       11           
  Lines         526      526           
  Branches      156      156           
=======================================
  Hits          525      525           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6ef8c...918b55b. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Mar 24, 2020

固定了以后,每次 rc-tree 更新都需要升级 rc-tree-select,感觉不是特别有必要。

@afc163
Copy link
Member Author

afc163 commented Mar 24, 2020

如果 antd 中依赖的 rc-tree@~3.1.0,这里依赖了 rc-tree@^3.1.0,那么以后底层发了 rc-tree@3.2.0 之后,antd 里是不是会打包两个版本的 rc-tree ?

@zombieJ
Copy link
Member

zombieJ commented Mar 25, 2020

嗯,但是从更新度上看,rc-tree 发 minor 不是特别高。分叉还是比较少的。

@afc163
Copy link
Member Author

afc163 commented Mar 25, 2020

先放着,以后遇到打包两份再说,之前以为打包超 300kb 是这个问题。

@afc163 afc163 closed this Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants