Skip to content

Conversation

muzea
Copy link
Contributor

@muzea muzea commented Sep 4, 2017

实现比较拙计

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.8%) to 61.29% when pulling bf4879f on muzea:master into c00f1bc on react-component:master.


componentDidMount() {
this.refs.file.directory = this.props.directory;
this.refs.file.webkitdirectory = this.props.directory;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 props 传递,而非通过引用修改。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjycui facebook/react#3468 :(
如果还要支持React15的话,就只能这么搞了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase 下 master,这个 ref 已经改掉了。

@benjycui
Copy link
Member

ping~

@muzea
Copy link
Contributor Author

muzea commented Nov 15, 2017

最近活比较多=_=,我看下我要改啥

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.4%) to 65.741% when pulling 7d5e9cf on muzea:master into ff74460 on react-component:master.

@muzea
Copy link
Contributor Author

muzea commented Nov 16, 2017

这个测试我没看懂应该怎么写:(

@marswong
Copy link

同样的需求,但是这个 feature 目前无法支持 ie 和 safari,还要加到 rc-upload 么?

@afc163
Copy link
Member

afc163 commented Apr 21, 2018

ci broken

@muzea
Copy link
Contributor Author

muzea commented Apr 21, 2018

😂等我明天爬起来改一下

@afc163
Copy link
Member

afc163 commented Apr 21, 2018

不急 🙃

@muzea muzea closed this Apr 24, 2018
@muzea muzea deleted the master branch April 24, 2018 05:33
@muzea
Copy link
Contributor Author

muzea commented Apr 24, 2018

刚才同步修改出了点偏差,重建了master分支:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants