feat: Support csp inject #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 51.17% 52.23% +1.05%
==========================================
Files 39 40 +1
Lines 809 829 +20
Branches 290 296 +6
==========================================
+ Hits 414 433 +19
- Misses 339 340 +1
Partials 56 56
Continue to review full report at Codecov.
|
shaodahong
reviewed
Mar 16, 2021
| } | ||
|
|
||
| const newNode = injectCSS(css, option); | ||
| newNode[MARK_KEY] = key; |
There was a problem hiding this comment.
这里设置有问题吧，rc-util-key 是不是太定向了点
There was a problem hiding this comment.
这个是为了让 update 能找到原始的 style，这边故意做的很定制。我补一下 test case。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
准备把注入相关的都收敛到 rc-util 里，去掉外部依赖。icons 还要加一下 csp 注入。
ref ant-design/ant-design#29763