-
Notifications
You must be signed in to change notification settings - Fork 191
fix: restore portal to dom #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/util/EUQE1QgiStCkfdMRC1jgr4cFFxZv |
| }); | ||
|
|
||
| useEffect(() => { | ||
| // Restore container to original place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch ref comment here in case other people want to know why:
https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors
|
Update package.json with React 18 and add test case about this change. |
Upgrading to React 18 will cause a breaking change, but this works with 17. |
|
or do we only update the version in |
devDeps not peerDeps~ |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 63.74% 63.97% +0.23%
==========================================
Files 44 44
Lines 935 941 +6
Branches 327 330 +3
==========================================
+ Hits 596 602 +6
Misses 301 301
Partials 38 38
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
It seems that enzyme does not works fine with React 18. |
Yes. antd has part moved: ant-design/ant-design#34787 |
|
Let me handle this migration. |
|
#289 Merged |
|
https://github.com/react-component/util/pull/288/files#r843545160 Patch a comment on the effect to tell why need this~ |
|
|
Add acontaineroption, so that we can avoid creating a new container every time