feat: Queue support #337
Merged
feat: Queue support #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 67.43% 67.90% +0.46%
==========================================
Files 47 47
Lines 1035 1050 +15
Branches 343 347 +4
==========================================
+ Hits 698 713 +15
Misses 298 298
Partials 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🐂的 |
MadCcc
reviewed
Sep 4, 2022
| const existStyle = findStyles(container).filter(node => | ||
| ['prepend', 'prependQueue'].includes(node[APPEND_ORDER]), | ||
| ); | ||
| if (existStyle.length) { |
There was a problem hiding this comment.
所以这里第一个 style 还是 prepend？qiankun 没劫持 prepend，会透出去，后面 exitStyle 找不到还是会继续 prepend？
There was a problem hiding this comment.
prepend 让 qiankun 处理就好了，否则 rc-util 就要做框架检测了，这样就变成针对 qiankun 的耦合了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepend=queue时，第一个 style 会添加到最前端，之后 style 会依次添加。ref ant-design/ant-design#36742