-
-
Notifications
You must be signed in to change notification settings - Fork 364
Support nested and custom fixture paths #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It simplify things and errors are surfaced first thing, no longer waiting until spoiled component/fixture is clicked on.
flaviusone
approved these changes
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
__fixtures__folders inside a nested component structure (E.g.components/Button/Button.jsx– @BrunoDF was having trouble with in #182), but also for custom fixture paths for cases where fixture files are kept separately from component files.In addition:
@flavius-tirnacop-hs @RadValentin please review. I'll refrain myself from making any other big PR soon! This one has almost as many removed as added lines anyway. Thanks!