Skip to content

Fix for touchscreen laptops: input could be switched between mouse an… #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Fix for touchscreen laptops: input could be switched between mouse an… #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/DraggableCore.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,18 @@ export default class DraggableCore extends React.Component {
this.props.onDrag(e, coreEvent);
};

onMouseDown: EventHandler = (e) => {
dragEventFor = eventsFor.mouse; // on touchscreen laptops we could switch back to mouse

return this.handleDragStart(e);
};

onMouseUp: EventHandler = (e) => {
dragEventFor = eventsFor.mouse;

return this.handleDragStop(e);
};

// Same as onMouseDown (start drag), but now consider this a touch device.
onTouchStart: EventHandler = (e) => {
// We're on a touch device now, so change the event handlers
Expand All @@ -415,9 +427,9 @@ export default class DraggableCore extends React.Component {

// Note: mouseMove handler is attached to document so it will still function
// when the user drags quickly and leaves the bounds of the element.
onMouseDown: this.handleDragStart,
onMouseDown: this.onMouseDown,
onTouchStart: this.onTouchStart,
onMouseUp: this.handleDragStop,
onMouseUp: this.onMouseUp,
onTouchEnd: this.onTouchEnd
});
}
Expand Down