Only apply user-select hack if drag is started #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the user-select hack is applied whenever mouseDown on an element matching the selector, with the right kind of click. But if the onStart method returns false then the drag is aborted, but the user-select hack is still applied. Because the drag is not running the hack is not unapplied on mouseUp. This leads to a whole series of ";user-select: none;; user-select: none;; ..." appearing on the body tag and the inability to select text on the page until a valid drag happens. This commit moves the hack application to after the last short circuit to ensure dragging is actually happening.
Collaborator
|
Nice work! I've seen this bug before but didn't have the time to track it down. Solid PR, and thanks for not committing built files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the user-select hack is applied whenever mouseDown on an
element matching the selector, with the right kind of click.
If the onStart method returns false then the drag is aborted, but
the user-select hack is still applied. Because the drag is not running,
the hack is not unapplied on mouseUp. This leads to a whole series of
";user-select: none;; user-select: none;; ..." appearing on the body tag
and the inability to select text on the page until a valid drag happens.
This commit moves the hack application to after the last short circuit
to ensure dragging is actually happening before disabling selection.
I've added a test case and also a box on the example page.