Skip to content

Refactor #173 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2016
Merged

Refactor #173 #179

merged 2 commits into from
Jul 19, 2016

Conversation

@STRML
Copy link
Collaborator

@STRML STRML commented Jul 19, 2016

Ref: #173 which needed tests & bit of generalization

Aeneas Rekkas (arekkas) and others added 2 commits July 19, 2016 12:57
@STRML
Resolves regression issue by introducing offsetParent to <Draggable…
f63f3d1 
…Core>

Allows nodes to use an arbitrary node as origin instead of the parent. This is useful, when the parent's position is changing. When used, resolves #170

This issue was introduced by a398097
@STRML
Refactor offsetParent prop & add test
6855c38
@STRML STRML merged commit e8024e4 into master Jul 19, 2016
@STRML STRML mentioned this pull request Jul 19, 2016
Closed
@STRML STRML deleted the pr/173 branch July 19, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@STRML