Skip to content

Changing translate(x, y) to translate3d(x, y, z) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Changing translate(x, y) to translate3d(x, y, z) #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/draggable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,14 @@ function createCSSTransform(style) {
// Replace unitless items with px
var x = style.x + 'px';
var y = style.y + 'px';
var out = {transform: 'translate(' + x + ',' + y + ')'};
var out = {transform: 'translate3d(' + x + ',' + y + ', 0px)'};
// Add single prefixed property as well
if (browserPrefix) {
out[browserPrefix + 'Transform'] = out.transform;
}
return out;
}


//
// End Helpers.
//
Expand Down
4 changes: 2 additions & 2 deletions specs/draggable.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe('react-draggable', function () {
expect(called).toEqual(true);
});

it('should render with translate()', function () {
it('should render with translate3d()', function () {
drag = TestUtils.renderIntoDocument(
<Draggable>
<div />
Expand All @@ -107,7 +107,7 @@ describe('react-draggable', function () {
TestUtils.Simulate.mouseUp(node);

var style = node.getAttribute('style');
expect(style.indexOf('transform: translate(100px, 100px);')).not.toEqual(-1);
expect(style.indexOf('transform: translate3d(100px, 100px, 0px);')).not.toEqual(-1);
});

it('should add and remove user-select styles', function () {
Expand Down