-
Notifications
You must be signed in to change notification settings - Fork 1
fix: resolve broken links in README files #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c249151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update replaces relative links and image sources in the English and Korean README files of the Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.changeset/public-pets-go.md (1)
5-5: Terminate the summary sentence with a period.A period is missing at the end of the description line; this trips markdown-lint and keeps style inconsistent with other changeset files.
-fix: resolve broken links in README files +fix: resolve broken links in README files.packages/react-native-youtube-bridge/README.md (1)
26-28: Addalttext for accessibility & markdown-lint (MD045) compliance.The newly-added absolute image link still lacks alternative text, which hurts accessibility tooling and triggers MD045. A short, descriptive alt text is enough:
- <img src="https://raw.githubusercontent.com/react-native-bridges/react-native-youtube-bridge/main/assets/example.gif" width="600" /> + <img alt="YouTube player example demo" src="https://raw.githubusercontent.com/react-native-bridges/react-native-youtube-bridge/main/assets/example.gif" width="600" />packages/react-native-youtube-bridge/README-ko_kr.md (1)
26-28:alt속성을 추가해 접근성과 MD045 경고를 함께 해결하세요.GIF 이미지를 절대 경로로 교체한 것은 👍입니다만,
alt텍스트가 없어 접근성·lint 모두에서 경고가 발생합니다.- <img src="https://raw.githubusercontent.com/react-native-bridges/react-native-youtube-bridge/main/assets/example.gif" width="600" /> + <img alt="YouTube player 예제 데모" src="https://raw.githubusercontent.com/react-native-bridges/react-native-youtube-bridge/main/assets/example.gif" width="600" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/public-pets-go.md(1 hunks)packages/react-native-youtube-bridge/README-ko_kr.md(3 hunks)packages/react-native-youtube-bridge/README.md(3 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/react-native-youtube-bridge/README.md
[grammar] ~244-~244: Use proper spacing conventions.
Context: ...-youtube-bridge/tree/main/packages/web). > [!NOTE] > webViewUrl Usage > - When ...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~283-~283: Use proper spacing conventions.
Context: ...-youtube-bridge/tree/main/packages/web). ### YouTube oEmbed API Use the `useYoutubeOE...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
packages/react-native-youtube-bridge/README-ko_kr.md
[grammar] ~244-~244: Use proper spacing conventions.
Context: ...bridge/tree/main/packages/web)를 참고해 주세요. > [!NOTE] > webViewUrl 활용법 > - `useInl...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~283-~283: Use proper spacing conventions.
Context: ...bridge/tree/main/packages/web)를 참고해 주세요. ### YouTube oEmbed API useYoutubeOEmbed 훅을...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
.changeset/public-pets-go.md
[grammar] ~5-~5: Place a period at the end of declarative sentences.
Context: ...ix: resolve broken links in README files
(QB_NEW_EN_OTHER_ERROR_IDS_000178)
🪛 markdownlint-cli2 (0.17.2)
packages/react-native-youtube-bridge/README-ko_kr.md
27-27: Images should have alternate text (alt text)
(MD045, no-alt-text)
Summary by CodeRabbit