Skip to content

fix: align inline baseUrl with IFrame origin #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

fix: align inline baseUrl with IFrame origin #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a9bcf
fix: align inline baseUrl with IFrame origin
saseungmin Aug 25, 2025
279d5bf
docs: update TSDoc for webViewUrl/inline behavior
saseungmin Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/fresh-drinks-slide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"react-native-youtube-bridge": patch
---

fix: align inline baseUrl with IFrame origin

- add trailing-slash handling for WebView baseUrl in inline mode
- propagate origin/playerVars into local HTML
- refine YoutubeView WebView source resolution
5 changes: 5 additions & 0 deletions .changeset/slow-kings-lay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-youtube-bridge": patch
---

docs: update TSDoc for webViewUrl/inline behavior
7 changes: 5 additions & 2 deletions packages/react-native-youtube-bridge/src/YoutubeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ function YoutubeView({
// biome-ignore lint/correctness/useExhaustiveDependencies: webViewProps.source is intentionally excluded to prevent unnecessary re-renders
const webViewSource = useMemo(() => {
if (useInlineHtml) {
const webViewBaseUrlWithSlash =
webViewBaseUrl && (webViewBaseUrl.endsWith('/') ? webViewBaseUrl : `${webViewBaseUrl}/`);

return {
html: createPlayerHTML(),
baseUrl: webViewBaseUrl ?? 'https://localhost/',
baseUrl: webViewBaseUrlWithSlash || 'https://localhost/',
};
}

Expand Down Expand Up @@ -111,7 +114,7 @@ function YoutubeView({
}
} catch (error) {
if (__DEV__) {
console.error('Error parsing WebView message:', error);
console.error('Error parsing WebView message:', error, event?.nativeEvent?.data);
}
player.emit('error', { code: 1000, message: 'FAILED_TO_PARSE_WEBVIEW_MESSAGE' });
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-youtube-bridge/src/hooks/useCreateLocalPlayerHtml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const useCreateLocalPlayerHtml = ({
return '<html><body><div style="width: 100%; height: 100%; display: flex; justify-content: center; align-items: center; color: #fff;">Invalid YouTube ID</div></body></html>';
}

const safeOrigin = escapeHtml(origin) ?? 'https://localhost';
const safeOrigin = escapeHtml(origin) || 'https://localhost';
const safeStartTime = safeNumber(startTime);
const safeEndTime = endTime ? safeNumber(endTime) : undefined;

Expand Down
5 changes: 3 additions & 2 deletions packages/react-native-youtube-bridge/src/types/youtube.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ export type YoutubeViewProps = {
* The URL for the WebView source.
* @remark
* When `useInlineHtml` is `true`, this value is set as the `baseUrl` for HTML content.
* In this case, the origin of `webViewUrl` MUST match the YouTube IFrame API `origin`
* (e.g. baseUrl `https://localhost/` ⇄ origin `https://localhost`).
* In this case, the origin of `webViewUrl` MUST exactly match the YouTube IFrame API `origin`.
* - Include the port when applicable (e.g. baseUrl `https://localhost:8081/` ⇄ origin `https://localhost:8081`).
* - Use a trailing slash on the `baseUrl`, but not on `origin` (scheme + host [+ port] only).
*
* When `useInlineHtml` is `false`, this value overrides the default URI for the WebView source (https://react-native-youtube-bridge.pages.dev).
* @platform ios, android
Expand Down