Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️Umbrella: TypeScript migration #683

Closed
31 tasks done
thymikee opened this issue Sep 9, 2019 · 30 comments · Fixed by #788
Closed
31 tasks done

☂️Umbrella: TypeScript migration #683

thymikee opened this issue Sep 9, 2019 · 30 comments · Fixed by #788
Labels
good first issue Good for newcomers help wanted infra Internal work not facing public APIs

Comments

@thymikee
Copy link
Member

thymikee commented Sep 9, 2019 •
edited by grabbou

Describe the Feature

Some time ago we started migrating CLI to TS package by package. The infrastructure is already set up, so we can work with TS and Flow files without issues.

Currently all packages except for packages/cli are converted. We need your help in converting the rest of the codebase 💪.

Work plan

If you'd like to help with migrating any of the packages mentioned below, please leave a comment and we'll assign it to you.

Commands

Commands live in separate directories. It makes sense to tackle them one by one.

Tools

Tools are helpers we use throughout the cli package. They have corresponding test files, which can be found in commands/tools/__tests__ directory. Those should also be converted.

Root index files in src/

Let's tackle this once we have all commands converted.
@FLGMwt
Copy link
Contributor

FLGMwt commented Sep 9, 2019

👋 Hey stranger ; D

I'm happy to give it a shot. I'd like to try to start with something small like commands/info. Could use some guidance about what to do about ConfigT from types which seems to be the only imported flow type.

@thymikee
Copy link
Member Author

thymikee commented Sep 9, 2019

Hey! You can find shared types like Config, Command etc in @react-native-community/cli-types package.

@netochaves
Copy link
Contributor

I would like to work in config if that's ok.

@thymikee thymikee mentioned this issue Sep 9, 2019
Merged
@thib92
Copy link
Contributor

thib92 commented Sep 9, 2019

Would love to take the ˋdoctor` command!

@thymikee
Copy link
Member Author

thymikee commented Sep 9, 2019

@netochaves @thib92 go for it!

@FLGMwt FLGMwt mentioned this issue Sep 9, 2019
Merged
@FLGMwt
Copy link
Contributor

FLGMwt commented Sep 9, 2019

I was pulling the thread on tools/releaseChecker so I can pull that and replacePathSepForRegex + walk + yarn in too.

@thymikee thymikee added good first issue Good for newcomers infra Internal work not facing public APIs labels Sep 9, 2019
@gvarandas
Copy link

I can tackle the commands/init 🤖

@DanielUche
Copy link

DanielUche commented Sep 9, 2019 •
edited

I will like to tackle commands/install

@Naturalclar
Copy link
Member

I'd like to help with commands/tools/merge.js

Naturalclar added a commit to Naturalclar/cli that referenced this issue Sep 9, 2019
@Naturalclar
chore: rename merge.js to merge.ts (react-native-community#683)
9c2e144
Naturalclar added a commit to Naturalclar/cli that referenced this issue Sep 9, 2019
@Naturalclar
chore: add type to deepmerge(react-native-community#683)
6e61a0b
Naturalclar added a commit to Naturalclar/cli that referenced this issue Sep 9, 2019
@Naturalclar
chore: add FlowFixMe temporarily for files converted to TS (react-nat…
748d573 
…ive-community#683)
@Naturalclar Naturalclar mentioned this issue Sep 9, 2019
Merged
@sasurau4
Copy link
Contributor

I'd like to help with commands/tools/copyFiles.js 👍

@netochaves netochaves mentioned this issue Sep 10, 2019
Merged
@anikethsaha
Copy link
Contributor

I can help with link command

@sasurau4 sasurau4 mentioned this issue Sep 10, 2019
Merged
@luizcieslak
Copy link

I'd like to work with commands/tools/copyAndReplace.js!

Esemesek pushed a commit that referenced this issue Sep 10, 2019
@Naturalclar @Esemesek
[#683] Convert merge.js to typescript (#687)
ed6205b 
* chore: rename merge.js to merge.ts (#683)

* chore: add type to deepmerge(#683)

* chore: add FlowFixMe temporarily for files converted to TS (#683)

* chore: add underscore in arg for unused param
@pveyes
Copy link
Contributor

pveyes commented Sep 10, 2019

I'd like to help with command/tools/findSymlinkedModules.js 👋

Esemesek pushed a commit that referenced this issue Sep 10, 2019
@sasurau4 @Esemesek
[#683] convert copyFiles from flow to typescript (#690)
cc2697a 
* convert copyFiles from flow to typescript

* add ts-ignore for FIXME comment

* fix flow-check
@konojunya
Copy link
Contributor

I'd like to help with commands/tools/assertRequiredOptions.js💪

@moriyuu
Copy link
Contributor

moriyuu commented Sep 10, 2019

I'd like to help with commands/tools/packageManager.js !

@konojunya konojunya mentioned this issue Sep 10, 2019
Merged
@radko93
Copy link
Contributor

radko93 commented Sep 10, 2019

I can do loadMetroConfig.js, isValidPackageName.js and assign.js

@assuncaocharles
Copy link
Contributor

Hey, I do like to start helping with
commands/tools/gracefulifyFs.js and then take something bigger. :D

Btw, it seems commands/tools/install.js is done

@Quadriphobs1
Copy link
Contributor

I'd like to help with commands/bundle 😄

Esemesek pushed a commit that referenced this issue Sep 10, 2019
@moriyuu @Esemesek
[#683] Convert commands/packageManager.ts to TS (#692)
48626dd 
* convert packageManager from flow to TS

* fix flow-check

* fix: remove Flow annotation

* convert packageManager-test from flow to TS

* fix eslint
@troZee
Copy link
Member

troZee commented Sep 10, 2019 •
edited

I would like to help with commands/tools/config/

WIP MR #710

@Quadriphobs1 Quadriphobs1 mentioned this issue Sep 10, 2019
Merged
@anikethsaha anikethsaha mentioned this issue Sep 10, 2019
Merged
@KangYoosam KangYoosam mentioned this issue Sep 10, 2019
Merged
@Quadriphobs1 Quadriphobs1 mentioned this issue Sep 10, 2019
Merged
@Noeza
Copy link

Noeza commented Sep 10, 2019

I would like to help if there are any files left, not yet taken

@thymikee
Copy link
Member Author

@Noeza you could take a look at e2e directory and convert tests. We would also use some help with reviewing PRs :)

@assuncaocharles assuncaocharles mentioned this issue Sep 10, 2019
Merged
@nitaking
Copy link

I want to raise my hand for the next help!

@Sly777
Copy link

Sly777 commented Sep 10, 2019

I can also help with code review or for converting tests.

@nickytonline
Copy link

Anything else to grab? I helped migrate the Refined GitHub extension to TS. Happy to work on any part of this.

@Quadriphobs1 Quadriphobs1 mentioned this issue Sep 10, 2019
Merged
@thymikee
Copy link
Member Author

Looks like we're out of work that's not assigned to anybody. But maybe we missed something, so feel free to identify that. If not, code review is always welcome. Or PRs improving type coverage!

@gvarandas gvarandas mentioned this issue Sep 10, 2019
Merged
8 tasks
@radko93 radko93 mentioned this issue Sep 11, 2019
Merged
@troZee troZee mentioned this issue Sep 11, 2019
Merged
11 tasks
@thib92 thib92 mentioned this issue Sep 11, 2019
Merged
6 tasks
@troZee
Copy link
Member

troZee commented Sep 11, 2019

@nitaking @Sly777 @nickytonline
I am struggling with this PR #710 . Can you help me with this ?

@nickytonline
Copy link

I'll take a peek tonight @PTROCKI.

@thib92 thib92 mentioned this issue Sep 13, 2019
Merged
2 tasks
This was referenced Sep 16, 2019
Merged
Merged
@Naturalclar Naturalclar mentioned this issue Sep 29, 2019
Merged
@thymikee thymikee mentioned this issue Oct 11, 2019
Merged
@grabbou
Copy link
Member

grabbou commented Oct 14, 2019

We have just replaced the remaining files as a part of #783.

@grabbou grabbou mentioned this issue Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted infra Internal work not facing public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: finish migration to TypeScript react-native-community/cli