chore: convert assertRequiredOptions to TS #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konojunya
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
requested changes
Sep 10, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Thanks for sending a PR! We can still make it better :)
Contributor
Author
|
@thymikee fixup :) |
thymikee
reviewed
Sep 10, 2019
thymikee
approved these changes
Sep 10, 2019
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
Esemesek
approved these changes
Sep 10, 2019
thymikee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #683
Converted
commands/tools/assertRequiredOptions.jsto typescriptTest Plan:
yarn test