chore: convert tools/config folder to TS

[troZee]

Part of #683 (comment)

Current progress

• findAssets-test
• findDependencies-test
• index-test
• errors
• findAssets
• findDependencies
• index
• readConfigFromDisk
• resolveNodeModuleDir
• resolveReactNativePath
• schema

Problem description:

File readConfigFromDisk.js contains methods, which use cosmiconfig dependency or just convert package.json file. I have a problem to type this readers correctly and map returned values into UserConfig or UserDependencyConfig. All methods from readConfigFromDisk file should return UserConfig or UserDependencyConfig(this type should be created based on schema validator).

[nickytonline]

Problem description:

File readConfigFromDisk.js contains methods, which use cosmiconfig dependency or just convert package.json file. I have a problem to type this readers correctly and map returned values into UserConfig or UserDependencyConfig. All methods from readConfigFromDisk file should return UserConfig or UserDependencyConfig(this type should be created based on schema validator).

It's not clear to me what you're having a hard time typing. Is it migrating the type from Flow to TypeScript that is the issue for you?

I created a TypeScript playground for getting started with the ConfigT and UserConfigT conversion from Flow.

I also came across this utility tonight which you may find helpful, care of Khan Academy, https://flow-to-ts.netlify.com.

[troZee]

There was a problem with UserConfig. This type returned never instead of object. It should be like you provided export type UserConfig = Omit<Config, 'root' | 'haste' | 'reactNativePath'>. That was really helpful @nickytonline, thank you.

[thymikee]

@PTROCKI I've pushed a bunch of adjustments to unblock you. This looks mostly good now, but I'd like you and @Esemesek to check it once again.

[troZee]

Tested below commands:

node ./cli/packages/cli/build/index.js init AwesomeCLI 
cd AwesomeCLI
yarn add -D @react-native-community/netinfo
cd ios && pod install && cd ..
node ../cli/packages/cli/build/index.js run-ios
node ../cli/packages/cli/build/index.js run-android
node ../cli/packages/cli/build/index.js config  

and it works for both platforms. In this case netinfo was added to project correctly.

[Esemesek]

Apart from 2 comments I left PR is LGTMT.