chore: converted install command to typescript #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quadriphobs1
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Member
|
Can you rebase and make sure lint is passing? :) |
Contributor
Author
|
@thymikee Can you check it now |
Member
|
The issues I brought are still there, please address them first. |
thymikee
approved these changes
Sep 10, 2019
Member
|
Thanks! |
|
wow some bit me to this task. I can take up any other task if any is available |
Member
|
@DanielUche sorry, I didn't notice it was assigned to somebody else. Currently we don't have any TS-related task left. But you're free to help us with regular issues and code reviews :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #683
Converted commands/install/* to typescript
Test Plan:
yarn test