chore: migrate upgrade command to TS and remove legacy implementation #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
thymikee
commented
Sep 9, 2019
thymikee
force-pushed
the
ts/upgrade
branch
3 times, most recently
from
52ec050 to
bc6760d
Compare
Esemesek
reviewed
Sep 9, 2019
| "typescript": "^3.6.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/plugin-proposal-class-properties": "^7.5.5" |
Member
Author
There was a problem hiding this comment.
tests are failing without this transform, not yet sure why
Esemesek
reviewed
Sep 9, 2019
| test('fetches regular patch, adds remote, applies patch, installs deps, removes remote when updated from nested directory', async () => { | ||
| mockFetch(samplePatch, 200); | ||
| (execa: any).mockImplementation(mockExecaNested); | ||
| ((execa as unknown) as jest.Mock).mockImplementation(mockExecaNested); |
Member
There was a problem hiding this comment.
I usually make it ((execa as any) as jest.Mock), which might be a little bit smaller. It doesn't really matter here :P
Esemesek
approved these changes
Sep 9, 2019
Member
Esemesek
left a comment
Esemesek
left a comment
There was a problem hiding this comment.
Seems legit. Those // $FlowFixMe are a little bit awkward, but I don't see any other solution to migrating module piece by piece.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #683
Had issues with inquirer module typings, they somehow clash with Node. Not sure how to resolve, help wanted :)
Btw decided to remove legacy upgrade implementation, it's about time.
Test Plan:
Green CI