chore: migrate config command to TS

[netochaves]

Summary:

Part of #683
Converted commands/config to typescript

Test Plan:

Green CI

[Esemesek]

I think this config can be typed as:

config: AndroidDependencyConfig | IOSDependencyConfig | null

[netochaves]

I'm having trouble to set the type of this parameter, I've tried this approach but it isn't working

[Esemesek]

What happened to the first argument of the function? Have you made sure everything works as expected with this change?

[thymikee]

Config is a second argument. This change breaks that. If argv is not used, prepend it with an underscore: _argv

[netochaves]

OK. I din't notice that, I'll fix it.

[thymikee]

Hey, thanks for the PR! Please implement the feedback from @Esemesek and rebase to latest master to resolve conflicts :)

[thymikee]

Looks like TS is failing

[assuncaocharles]

Just an idea, but maybe we want to the Dependency in @react-native-community/cli-types as an interface like:

export interface Dependency {
  [key: string]: {
    name: string;
    root: string;
    platforms: {
      android?: AndroidDependencyConfig | null;
      ios?: IOSDependencyConfig | null;
      [key: string]: any;
    };
    assets: string[];
    hooks: {
      prelink?: string;
      postlink?: string;
    };
    params: InquirerPrompt[];
  };
}

Don't forgetting to update the Config interface to dependencies: {[key:string] Dependacy }; and here we can use:

import {
  Dependency
} from '@react-native-community/cli-types';

function isValidRNDependency(
  config: Dependency
) {
  return (
    Object.keys(config.platforms).filter(key => Boolean(config.platforms[key]))
      .length !== 0 ||
    (config.hooks && Object.keys(config.hooks).length !== 0) ||
    (config.assets && config.assets.length !== 0) ||
    (config.params && config.params.length !== 0)
  );
}

It would solve most of the problems breaking in this file

[thymikee]

Yea, makes sense to extract this. We used this type in Flow files:

cli/types/index.js

Lines 172 to 175 in fde227d

	export type DependencyConfigT = $PropertyType<
	$PropertyType<ConfigT, 'dependencies'>,
	'[key: string]',
	>;

@Esemesek can you take it over?

[netochaves]

@Esemesek is working on this? if not I would like to.

[thymikee]

@netochaves sure, please do!

[netochaves]

Should i create a new pr for this?

[thymikee]

nah, do it here

[netochaves]

Done.

[assuncaocharles]

Nice!

CI breaking

[thymikee]

Thank you!