Migrate doctor command to TypeScript

[thib92]

Summary:

Migrate packages/cli/src/commands/doctor to TypeScript, with the exported type definitions in cli-types.

Related to #683

Current progress:

• healthchecks/**
• doctor
• index
• printFixOptions
• runAutomaticFix
• versionRanges

Test Plan:

CI should be green

[thib92]

I'm having an issue trying to move the exported types to cli-types, and I'm not sure how to resolve it:

When I try to move the types.js Flow file to the cli-types folder and export them with the cli-types package, I have some TypeScript errors regarding the version of the Node typings. I don't know how to fix this, and it's blocking me from moving the rest of the files to TS, since they all use these type definitions. If anyone has an idea on how to fix these, I'm all ears!

[thymikee]

Which types you try to "move"? cc @lucasbento who's working on doctor command and may help you with some issues :)

[lucasbento]

Solid work, thank you for doing this @thib92!

I would go with merging this in small chunks if possible as a lot of stuff is being changed on doctor as it's still WIP.

[thib92]

@thymikee thanks for the response. I thought that cli-types was a package for all exported types. My bad.

I wanted to "move" the types.js file which contains the Flow types for the doctor command.

Therefore, moving it to types.ts sounds like a good solution.

@lucasbento sure. Now that I have an answer to my question, I'll make a minimal passing build so that it can be merged soon to allow continuous work on the command.

[thib92]

@thymikee @lucasbento I think the PR is good to review as is. I moved to the types to the doctor command in the cli package as asked.

The flow check is failing now, since some JS files are trying to import files converted to TS.

Should I remove the // @flow-check mark from the files for the doctor command so that CI is green again, just for the time to migrate to TS?

[thymikee]

If the file is js, leave flow alone, just add $FlowFixMe comments to the imports of TS files. See how it's done in other modules :)

[thib92]

Great! That's a lot of $FlowFixMe, will need to get this moved to TS fast 😄

[thymikee]

Thanks, looks good. @lucasbento could you please check it as well?

[lucasbento]

This awesome ❤️

[thib92]

Thanks for the review @thymikee @lucasbento
I'll get started on another PR to continue the work.