Skip to content

chore: remove node-notifier to reduce install size #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2020
Merged

chore: remove node-notifier to reduce install size #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"minimist": "^1.2.0",
"mkdirp": "^0.5.1",
"morgan": "^1.9.0",
"node-notifier": "^5.2.1",
"open": "^6.2.0",
"ora": "^3.4.0",
"plist": "^3.0.0",
Expand All @@ -80,7 +79,6 @@
"@types/minimist": "^1.2.0",
"@types/mkdirp": "^0.5.2",
"@types/morgan": "^1.7.37",
"@types/node-notifier": "^5.4.0",
"@types/pretty-format": "^24.3.0",
"@types/semver": "^6.0.2",
"@types/wcwidth": "^1.0.0",
Expand Down
13 changes: 5 additions & 8 deletions packages/cli/src/commands/server/messageSocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import url from 'url';
import {Server as WebSocketServer} from 'ws';
import notifier from 'node-notifier';
import {logger} from '@react-native-community/cli-tools';
import {Server as HttpServer} from 'http';
import {Server as HttpsServer} from 'https';
Expand Down Expand Up @@ -100,13 +99,11 @@ function attachToServer(server: Server, path: string) {
params: message.params,
};
if (clients.size === 0) {
notifier.notify({
title: 'React Native: No apps connected',
message:
`Sending '${message.method}' to all React Native apps ` +
'failed. Make sure your app is running in the simulator ' +
'or on a phone connected via USB.',
});
logger.warn(
`No apps connected. Sending "${
message.method
}" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.`,
);
}
for (const [otherId, otherWs] of clients) {
if (otherId !== broadcasterId) {
Expand Down
7 changes: 0 additions & 7 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2897,13 +2897,6 @@
dependencies:
"@types/node" "*"

"@types/node-notifier@^5.4.0":
version "5.4.0"
resolved "https://registry.yarnpkg.com/@types/node-notifier/-/node-notifier-5.4.0.tgz#4e66c85eb41cce8387b4cd9c6c67852be41a99db"
integrity sha512-M1XvCG6Rwej6+W0+kWultE46YS7erOy+W7suRmXtKwLGT3ytj6YEe9lqo47nRfL1xILzg9xJpKeNczIsWR8ymw==
dependencies:
"@types/node" "*"

"@types/node@*":
version "12.0.0"
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.0.0.tgz#d11813b9c0ff8aaca29f04cbc12817f4c7d656e5"
Expand Down