fix: building TS definitions broken by include package.json #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
commented
Feb 22, 2020
| import loadConfig from './tools/config'; | ||
|
|
||
| import pkgJson from '../package.json'; | ||
| const pkgJson = require('../package.json'); |
Member
Author
There was a problem hiding this comment.
TS is able to resolve package.json, but with a require. This is the actual fix, rest is errors that accumulated since the bug started happening
thymikee
commented
Feb 22, 2020
| {"path": "../cli-types"}, | ||
| {"path": "../debugger-ui"} | ||
| ], | ||
| "include": ["../package.json"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed that type defs were not built properly for
packages/cli. The reason was"include": "../package.json"in TS config, which resulted in TS happily passing everything. Seems like a bug in TS, present on both 3.7 and 3.8.Test Plan:
Type defs are there in
build/dirs