Open /events for locally served javascript files as well
#1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a production build of flipper, the network requests are made from a pre-bundled javascript file, which results in an origin header based on a local file url. In a future we will make sure that this origin is consistent both in prod- and non-prod builds, but for compatibility reasons making sure it will be compatible with the next react-native CLI version as well Facebook: this corresponds with diff D20001690
mweststrate
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Esemesek
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When using a production build of flipper, the network requests are made from a pre-bundled javascript file, which results in an origin header based on a local file url. In a future we will make sure that this origin is consistent both in prod- and non-prod builds, but for compatibility reasons making sure it will be compatible with the next react-native CLI version as well
Facebook: this corresponds with diff D20001690
Test Plan:
Before:
After: