fix: avoid crashing if build.gradle is missing #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Feb 26, 2020
| const buildToolsVersionEntry = 'buildToolsVersion'; | ||
|
|
||
| if (!fs.existsSync(gradleBuildFilePath)) { | ||
| return ''; |
Member
There was a problem hiding this comment.
Can we return Not Found instead? I don't feel too good about returning an empty string, but this way we could be consistent. It also seems like this function can return either non-empty string or Not Found. Which makes code on line 52 unreachable. Can you investigate and remove stuff if possible?
Contributor
Author
|
My first reaction was to use "Not found" but then I saw that the caller had a case for empty/no string and I assumed it was for this particular case.
I also prefer having less cases 😊 I will take a look as soon as I can and update the PR.
Thanks!
|
molant
force-pushed
the
fix/gradle-crash
branch
from
9c14fc3 to
c84372a
Compare
thymikee
approved these changes
Feb 26, 2020
molant
force-pushed
the
fix/gradle-crash
branch
from
c84372a to
1eeb05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Working on #976 I had some issues making the CLI crash when
build.gradleis missing.Test Plan: