Skip to content

fix: don't log watch mode not supported to stdout (fixes Expo) #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

fix: don't log watch mode not supported to stdout (fixes Expo) #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/src/commands/server/watchMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ function printWatchModeInstructions() {
}

function enableWatchMode(messageSocket: any) {
readline.emitKeypressEvents(process.stdin);

// We need to set this to true to catch key presses individually.
// As a result we have to implement our own method for exiting
// and other commands (e.g. ctrl+c & ctrl+z)
if (!process.stdin.setRawMode) {
logger.log('Watch mode is not supported in this environment');
logger.debug('Watch mode is not supported in this environment');
return;
}

readline.emitKeypressEvents(process.stdin);

process.stdin.setRawMode(true);

// We have no way of knowing when the dependency graph is done loading
Expand Down