Skip to content

feat: bail out when initializing new project to pre-existing directories #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2020
Merged

feat: bail out when initializing new project to pre-existing directories #1036

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df98c70
fix: init with directory option set to .
Esemesek Mar 4, 2020
49efee1
Remove initializing to pre-existing directory
Esemesek Mar 4, 2020
ff7f23e
Remove lint errors
Esemesek Mar 4, 2020
06b8d6b
Bring back relative names
Esemesek Mar 4, 2020
0ffa3c2
Consistent names everywhere
Esemesek Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions packages/cli/src/commands/init/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import fs from 'fs-extra';
import minimist from 'minimist';
import ora from 'ora';
import semver from 'semver';
// @ts-ignore untyped
import inquirer from 'inquirer';
import mkdirp from 'mkdirp';
import {validateProjectName} from './validate';
import DirectoryAlreadyExistsError from './errors/DirectoryAlreadyExistsError';
Expand Down Expand Up @@ -47,32 +45,16 @@ function doesDirectoryExist(dir: string) {
}

async function setProjectDirectory(directory: string) {
const directoryExists = doesDirectoryExist(directory);
if (directoryExists) {
const {shouldReplaceprojectDirectory} = await inquirer.prompt([
{
type: 'confirm',
name: 'shouldReplaceprojectDirectory',
message: `Directory "${directory}" already exists, do you want to replace it?`,
default: false,
},
]);

if (!shouldReplaceprojectDirectory) {
throw new DirectoryAlreadyExistsError(directory);
}

fs.emptyDirSync(directory);
if (doesDirectoryExist(directory)) {
throw new DirectoryAlreadyExistsError(directory);
}

try {
mkdirp.sync(directory);
process.chdir(directory);
} catch (error) {
throw new CLIError(
`Error occurred while trying to ${
directoryExists ? 'replace' : 'create'
} project directory.`,
'Error occurred while trying to create project directory.',
error,
);
}
Expand Down