chore: add deprecation messages for manual linking #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Mar 4, 2020
| ctx: Config, | ||
| opts: FlagsType, | ||
| ) { | ||
| printDeprecationWarning('link'); |
Member
There was a problem hiding this comment.
link command itself links assets by default, which is still supported – maybe we should rename it to link-assets? Not sure what's best here. The thing is that link [packageName] and link --all get deprecated and we need a clear path forward
Member
Author
There was a problem hiding this comment.
Oh righty. Forgot about the assets.
Member
Author
|
And this is roughly how it looks like: |
thymikee
force-pushed
the
link-deprecated
branch
from
80158fc to
1bd1327
Compare
thymikee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Let's finally deprecate linking commands C:
Test Plan:
Deprecation warning prints correctly.