Skip to content

chore: remove setting hasteImplModulePath in Metro config #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

chore: remove setting hasteImplModulePath in Metro config #1041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/cli/src/tools/loadMetroConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import path from 'path';
// @ts-ignore - no typed definition for the package
import {loadConfig} from 'metro-config';
import {existsSync} from 'fs';
import {Config} from '@react-native-community/cli-types';
import findSymlinkedModules from './findSymlinkedModules';

Expand Down Expand Up @@ -38,7 +37,6 @@ export interface MetroConfig {
resolverMainFields: string[];
platforms: string[];
providesModuleNodeModules: string[];
hasteImplModulePath: string | undefined;
};
serializer: {
getModulesRunBeforeMainModule: () => string[];
Expand Down Expand Up @@ -67,15 +65,11 @@ export interface MetroConfig {
* Otherwise, a.native.js will not load on Windows or other platforms
*/
export const getDefaultConfig = (ctx: Config): MetroConfig => {
const hasteImplPath = path.join(ctx.reactNativePath, 'jest/hasteImpl.js');
return {
resolver: {
resolverMainFields: ['react-native', 'browser', 'main'],
platforms: [...ctx.haste.platforms, 'native'],
providesModuleNodeModules: ctx.haste.providesModuleNodeModules,
hasteImplModulePath: existsSync(hasteImplPath)
? hasteImplPath
: undefined,
},
serializer: {
getModulesRunBeforeMainModule: () => [
Expand Down