chore: remove haste and rnpm #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
chore/remove-haste
branch
from
a42ce4b to
a61170c
Compare
Member
Author
|
cc @brentvatne @acoates-ms as Expo and RNWindows may be affected |
Esemesek
approved these changes
Mar 10, 2020
Member
|
Nice! I think this is similar to some of the work I've done on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
rnpmis deprecated since v2, so it's about time to remove it.--platformflag fromstartas it was not used anywayThis forces Windows platform to adapt to new config format.
There's no rush merging that, but I think we should be pretty safe by now.
Test Plan:
Updated tests, but please make sure to test it thoroughly