fix(cli-types): publish declaration files in npm package #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm ok with this (the tradeoff is adding 13.6kB to the download size), but maybe we can make it better with https://github.com/Microsoft/dts-gen, what do you think? |
Contributor
Author
|
Looks like that tool only generates declaration files from JS, whereas we already have it all typed out. |
thymikee
approved these changes
Mar 10, 2020
Member
|
cc @Esemesek if you have better ideas :) |
Contributor
Author
|
Thanks for merging - is it possible to get a release? :) |
Member
|
Yup, will followup as soon as I can |
Member
|
Published v4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently external plugin authors using TS cannot access the
cli-typesdeclaration files as they're not published to NPM. This change removes the file exclusion allowing them to be published.cc @thymikee as discussed on Discord