feat: run pod repo update when pod install failed
#1061
Conversation
grabbou
changed the title
pod repo when pod install failedpod repo update when pod install failed
|
With this PR applied, I was able to successfully continue manual tests of the upcoming release. |
| await runPodInstall(loader, projectName, false); | ||
| } else { | ||
| loader.fail(); | ||
| throw new Error( |
There was a problem hiding this comment.
Let's use CLIError and pass the original error so that issues like this one are easier to deal with. Would be cool to do the same for runPodUpdate function (line 68)
There was a problem hiding this comment.
Was just copying and pasting the existing code and actually started thinking why we no longer use CLIError.
There was a problem hiding this comment.
Turns out this will take more than should be in scope of this PR and I guess we should track it separately.
CLIError will inline the entire message into a single line + we already logger.error here (in other CLI commands, we don't do that as we have global try-catch).
I would be a bit nervous about changing it here due to potential side effects. What you think of setting up a follow up issue?
Summary:
Fixes #1060
Test Plan:
Run
pod installon outdated repo. Also includes a mechanism to prevent loops in casepod repo updatedidn't fix the error (e.g. invalid version specified).