Skip to content

feat: remove assetsDest checking #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2020
Merged

feat: remove assetsDest checking #1064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a8054e
feat: remove assetsDest checking
adrianha Mar 23, 2020
32b9b91
Remove unused
adrianha Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/cli/src/commands/bundle/saveAssets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import fs from 'fs';
import filterPlatformAssetScales from './filterPlatformAssetScales';
import getAssetDestPathAndroid from './getAssetDestPathAndroid';
import getAssetDestPathIOS from './getAssetDestPathIOS';
import {logger, CLIError} from '@react-native-community/cli-tools';
import {logger} from '@react-native-community/cli-tools';
import {AssetData} from './buildBundle';

interface CopiedFiles {
Expand All @@ -30,12 +30,6 @@ function saveAssets(
return Promise.resolve();
}

if (!fs.existsSync(assetsDest)) {
throw new CLIError(
`The specified assets destination folder "${assetsDest}" does not exist.`,
);
}

const getAssetDestPath =
platform === 'android' ? getAssetDestPathAndroid : getAssetDestPathIOS;

Expand Down