Skip to content

Fix: allow Hermes Debugger to connect from Flipper #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Fix: allow Hermes Debugger to connect from Flipper #1086

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85e9992
Fix: allow Hermes Debugger to connect from Flipper
mweststrate Mar 31, 2020
17acbbf
Fixed compile errors
mweststrate Mar 31, 2020
beb6d53
Fix lint error
mweststrate Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,10 @@ export default function getSecurityHeadersMiddleware(
res: http.ServerResponse,
next: (err?: any) => void,
) {
// @ts-ignore Property 'client' does not exist on type 'IncomingMessage', verify
const address = req.client.server.address();

// Block any cross origin request.
if (
req.headers.origin &&
req.headers.origin !== `http://localhost:${address.port}`
typeof req.headers.origin === 'string' &&
!req.headers.origin.match(/^https?:\/\/localhost:/)
) {
next(
new Error(
Expand Down