fix: don't use appIdSuffix to generate run task #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ref. discussion in #1085
Upgrade to CLI v4.4 breaks normal usage of
--appIdSuffix. Bug was introduced with 19ac71f#diff-b668aefc66b33ed6e984d3467db0abc1R54 whereappIdSuffixis concatenated tovariantin order to generate the run task name.The suffix should probably only be used to launch the correct package, and not for deciding what to build. If the user needs to specify some build type + flavor, the best thing is to put the full variant name in
--variant.Test Plan:
applicationIdSuffixto thedebugbuildType inandroid/app/build.gradle:npx react-native run-android --appIdSuffix debugto verify that justappIdSuffixworksandroid/app/build.gradle:npx react-native run-android --appIdSuffix demo.debug --variant demoDebugto verify that variant and appIdSuffix works.