Skip to content

Conversation

@Esemesek
Copy link
Member

@Esemesek Esemesek commented Oct 7, 2021

Summary:

Fixes #1456

Seems like our special treatment of package.json during init caused not everything to be replaced correctly. With this fix everything will be replaced correctly except the name won't be converted to lowercase npmjs package naming.

Test Plan:

Added test case assertions for this one in the editTemplate.test.ts.

@Esemesek
Copy link
Member Author

Esemesek commented Oct 8, 2021

@thymikee @grabbou What do you think about parsing package.json additionally to convert the name keyword to be lowercased?

@Esemesek Esemesek changed the title WIP: Fix init for package.json file fix: template name replacement in package.json Oct 8, 2021
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change. @grabbou WDYT? I wouldn't bother about the package name in package.json, because we don't init libraries.

@grabbou grabbou merged commit 0646299 into master Jan 24, 2022
@grabbou grabbou deleted the fix/init-packagejson branch January 24, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template's placeholderName is not replaced everywhere.

4 participants