Bump ora to 6.x #1522
Merged
Bump ora to 6.x #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianjensen
requested review from
Esemesek,
grabbou and
thymikee
as code owners
stianjensen
force-pushed
the
bump-ora
branch
from
c643882 to
6e2aa90
Compare
grabbou
reviewed
Jan 21, 2022
Contributor
Author
|
Something seems wrong with the lint, but I can't really figure out what. Is there an issue with the Also, should I worry about the E2E test being red? I can't really see how the test failures are connected to this PR. |
Main changes are a minimum node version requirement of 12.2, and that it's pure ESM now: https://github.com/sindresorhus/ora/releases
auto-merge was automatically disabled
January 22, 2022 15:31
Head branch was pushed to by a user without write access
Contributor
Author
Nothing beats coming back to it with fresh eyes. The trick is type-only imports (which luckily is just supported from the current TS version - 3.8, https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The main changes include a new minimum node version requirement of 12.2, and that
the module is pure ESM now:
https://github.com/sindresorhus/ora/releases