[android] Refine and test the findLibraryName function #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jun 30, 2022
|
|
||
| if (match) { | ||
| return match[1]; | ||
| } else { |
There was a problem hiding this comment.
no need for else when we return
There was a problem hiding this comment.
Should I follow up on this in a separate PR?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Here I'm extending the
findLibraryNamefunction to do the following:codegenConfig.namein the package.json in the root (if available)This implements the remaining points listed here facebook/react-native#33777 (comment)
Test Plan:
I've wrote a small test suite for
findLibraryNameas it was empty.