fix: use absolute path for iOS when user sourceDir is set #1672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When setting iOS
sourceDirinreact-native.config.js, it doesn't convert the relative path to absolute as it does for Android.Not having an absolute
sourceDircould cause an issue similar to the one below:When
userConfig.sourceDiris not set, it uses the absolute project path which makes sense.Test Plan:
I tested by building and creating an alias in
node_modulesfor@react-native-community/cli-platform-ioson my current react native app and runningyarn react-native config.